nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

WFTask.pm AddFile sub change with TS6.1

lhdavis

Just wanted to let everyone know about a hiccup that I found when validating some of my custom workflow code after my upgrade from TS6.0 to TS6.1.

We have an external script that runs iwpt_compile.ipl to generate an output file and then we use the TeamSite::WFtask AddFile subroutine to add the file to the task. Works fine and dandy in TS6.0.

After our upgrade to 6.1, I found that my call to AddFile no longer was working for one section of our script. After further investigation, it turns it that this behavior was due to now including a comment in my call to the subroutine.

In 6.1:
$my_task->AddFile("$website\\index.html") does not work
$my_task->AddFile("$website\\index.html", "Generated") does work

Looks like in 6.1 the AddFile subroutine was modified to call the iwaddtaskfile CLT using the "call_clt" subroutine in WFutils.pm. And this no longer allows you the option of not adding a comment for files being added.

Maybe I haven not RTFM as carefully as I could but I could not find this documented anywhere, in release notes, installation guides, TechNote 51304 on the Perl Upgrade for TS 6.1, or anywhere else.

Has anyone found anything similar to these kind of issues?

Lissa, are changes like this documented anywhere that we can see?

Luke Davis
Open Technology Group, Inc.
luke.davis@med.va.gov

Find more posts tagged with

Comments

Migrateduser

As far as what's documented for SP1, the Release Notes are what is provided. You said you checked that. I'll ask around to see if this was a deliberate change.

Regards,

lissa

Migrateduser

Interwoven should pay you for regression testing their ****, Luke. This is so unacceptable.

Dave Smith
Sr. Software Engineer
Nike, Inc.
(503) 671-4238
DavidH.Smith@nike.com

lhdavis

Just to be clear, I have not applied SP1 yet (baby steps here).

But here are the two versions of the subroutine (no mention that comment is required).

TS 6.0 WFtask.pm AddFile subroutine:
=head2 AddFile($path, $comment)

Adds a file with comment to a task.

Path and comment should be specified in UTF-8 encoding.

Paths should be specified with respect to root of task areavpath (no leading slash).

Returns zero on error, non-zero if successful.

=cut

sub AddFile
{
my ($this, $path, $comment) = @_;

$this->{xml_valid} = 0;

if ($^O eq "MSWin32") {
my $pobj;
my $ret = 1;
# Under Windows , CLT interface requires the command line arguments to be passed in in Native encoding.
# We will assume the native encoding to be IW Server native encoding...
my ($NativePath, $NativeComment) ;
$NativePath = UTF8ToNative_2($path);
$NativeComment = UTF8ToNative_2($comment);

if (Win32: Smiley Tongue

rocess::Create($pobj,
"$iwhome\\bin\\iwaddtaskfile.exe",
#CLT should anchored to IW Server locale... Use "-a" to instruct the CLT to anchor to IW Server Locale
"iwaddtaskfile -a $this->{id} \"$NativePath\" \"$NativeComment\"",
0,
NORMAL_PRIORITY_CLASS,
"$iwhome\\bin"))
{
$pobj->Wait(INFINITE);
$pobj->GetExitCode($ret);
return $ret == 0;
}
else
{
print STDERR Win32::FormatMessage(Win32::GetLastError());
return 0;
}
}
else
{
my $program = "$iwhome/bin/iwaddtaskfile";

# Under Unix system, UTF8 data can be passed in as command line argument.
# Since no LANG info is provide, CLT will be forked and run in C locale
# due to the implementation of TI18NUtils.cpp
# The command line argument will not be converted and the UTF8 data
# will be passed through to TeamSite server...
my $retcode = system($program,
$this->{id},
$path,
$comment);
return $retcode == 0;
}
}

TS 6.1 WFtask.pm AddFile subroutine:
=head2 AddFile($path, $comment)

Adds a file with comment to a task.

Path and comment should be specified in UTF-8 encoding.

Paths should be specified with respect to root of task areavpath (no leading slash).

Returns zero on error, non-zero if successful.

=cut

sub AddFile
{
my ($this, $path, $comment) = @_;

$this->{xml_valid} = 0;

my $ret = TeamSite::WFutils::call_clt( "iwaddtaskfile",
$this->{id},
$path,
$comment );
return (0 == $ret);
}

Luke Davis
Open Technology Group, Inc.
luke.davis@med.va.gov