Help with doCheckin / tbo

Hi,

We have some workflow automation menus in webtop.

The user selects an item, it opens a template (such as a word document) in the checked out state, and when the user chooses

check in, it runs my code and starts a workflow. However, if the user changes a property before checkin, it also starts the workflow.

I had looked at moving this code to doCheckin, but after some research, it seems that for new documents, it calls doSave. If I re-checkout, and checkin the document, it calls doCheckin.

What I would like to have happen is for this to only be called on checkin.

Any ideas or help would be appreciated.

Find more posts tagged with

Comments

p5C0U5dOmY1230900515271

Hi Brent,

It seems the tbo logic where your Auto processes are being triggered is having some issues. Unless the tbo code is reviewed or you provided the snippet of it, its hard to determine the cause behind this issue.

Please check with your Developers or check if the logic is proper and is it happening for other WFs too.

Regards,

Rakesh

bpathakis

Thanks for the help

Here's a snippet for the tbo:


protected void doSave( boolean saveLock, String versionlabel,
  Object extendedArgs[] ) throws DfException
  {


  Util.setCab (this);
  String div_tmp = "DSHW";
  if(isConverted ()) div_tmp = "DSHW_TIF";

  if(this.isCheckedOut ()
  && !Tools.IsWorkFlowStarted (this.getString ("r_object_id"),
  getSession ())
  && Util.isTemplate (this)){
  Util.startWF (this,"dshw_document",getSession ());
  }

This works as it starts the workflow on checkin. But if a users edits the properities before checkin, it will start one then instead.

I only want it to run during checkin.

But the doCheckin method never runs. I've stepped through it with remote debugger but it never seems to run.

PanfilovAB

There are the cases for checkin operation:

user creates new version - you should override doCheckin() method
user saves document to the same version - you code
user saves document to the same version but retains lock - you should pay attention to the saveLock flag in your code

bpathakis

Thanks.

I've tried this:

if(this.isCheckedOut ()

&& !Tools.isDocumentLocked (this)

&& !Tools.IsWorkFlowStarted (this.getString ("r_object_id"),

getSession ())

&& Util.isTemplate (this)){

Util.startWF (this,"dshw_document",getSession ());

}

The isDocumentLocked method is fairly simple:

boolean bLocked = false;

try{

String slockOwner = sysObj.getLockOwner ();

if(StringUtils.isNotEmpty (slockOwner)){

bLocked = true;

}else{

bLocked = false;

}

catch(Exception e){

And I've tried variations on this with no luck.

Thanks for looking.

}

return bLocked;

PanfilovAB


protected void doSaveSuper(boolean saveLock, String versionlabel,
        Object extendedArgs[]) throws DfException {
    super.doSave(saveLock, versionlabel, extendedArgs);
}

protected boolean shouldStartWF(boolean saveLock) throws DfException {
    if (saveLock) {
        return false;
    }

    if (!isCheckedOut()) {
        return false;
    }

    if (Tools.IsWorkFlowStarted(getObjectId().getId(), getSession())) {
        return false;
    }

    return Util.isTemplate(this);
}

protected void doSave(final boolean saveLock, final String versionlabel,
        final Object extendedArgs[]) throws DfException {
    final boolean startWF = shouldStartWF(saveLock);
    new TransactionalFunctorWithRetry(getObjectSession(), new Functor() {
        @Override
        public Object evaluate() throws DfException {
            doSaveSuper(saveLock, versionlabel, extendedArgs);
            if (startWF) {
                Util.startWF(this, "dshw_document", getSession());
            }
            return null;
        }
    }, true).evaluate();
}

bpathakis

Thanks very much for the help.

You ideas worked.