Perl method for getting files under a dir in Win32

I can't believe this isn't more obvious to me, but does anyone have any suggestions as to which module/method exists in the default TS installation to return a list of files beneath a directory on Windows?

E.g.

my @files = Some::Module::get_all_files_below_dir("C:/Temp");

I see that File::Listing is **** close, but it's only implemented for Unix "ls -l" type output.

I was playing around with File::Find for a while, but my problem there is that I want to be able to push files on to an array, but all the syntax for defining the wanted() method or a preprocess method don't support passing them arguments...so I'd be left manipulating a global array, and that ain't thread safe for a module that'll be used across lots of different modules.

Find more posts tagged with

Comments

Tbag

I found a google-cached version of File::Find::Closures by Brian D Foy that steered me in the right direction.

Here's how to get a recursive list of all the files (and only files) beneath a directory in windows:


#!C:\Interwoven/TeamSite/iw-perl/bin/iwperl -w

use strict;
use File::Find;

my( $wanted, $list_reporter ) = find_just_files();

my @directories = qw(C:/Temp);
File::Find::find( $wanted, @directories );

my @files= $list_reporter->();

foreach (@files) {
    print " --> $_ \n";
}

sub find_just_files {
    my @found = ();

    my $finder   = sub { push @found, $File::Find::name if -f };
    my $reporter = sub { @found };

    return( $finder, $reporter );
}

Migrateduser

Check out the TeamSite: Smiley Very Happy

irwalk module.

ISCBorisB

You can certainly use a canon to shoot sparrows. In my opinion it's a questionable idea
regardless of the effectiveness. How about Windows 'dir' command?

# Files only, Subdirectories ignored
my @files = map {chomp $_; $_;} qx(dir /B /A-D /ON YourStartingDirectory);

# Files only, with Subdirectories recursion
my @files = map {chomp $_; $_;} qx(dir /B /S /A-D /ON YourStartingDirectory);

Adam Stoller

You can certainly use a canon to shoot sparrows. In my opinion it's a questionable idea
regardless of the effectiveness. How about Windows 'dir' command?

# Files only, Subdirectories ignored
my @files = map {chomp $_; $_;} qx(dir /B /A-D /ON YourStartingDirectory);

# Files only, with Subdirectories recursion
my @files = map {chomp $_; $_;} qx(dir /B /S /A-D /ON YourStartingDirectory);

I prefer to use built-in's as much as possible - and often times I just write a simple recursive function - like:

my @list;
my $start_dir = "/some/path";
process_dir($start_dir, \@list);
print "$start_dir:\n\t" , join("\n\t", @list), "\n";
exit 0;

sub process_dir {
    my($dir, $listref) = @_;
    my @subdirs;
    opendir(DIR, $dir) || die "[opendir] '$dir' ($!)";
    my @entries = grep { !/^\./ } readdir(DIR);
    closedir(DIR);
    foreach my $e (@entries){
        if (-d "$dir/$e") {
            push(@subdirs, "$dir/$e");
        }
        else {
            push(@{$listref}, "$dir/$e");
        }
    }
    process_dir($_) foreach(@subdirs);
}

The nice thing about this is that you can easily adjust the code to traverse branches without going through every edition, and/or every workarea, and/or staging (depending on your needs) and/or add additional filters to find only HTML files, or only DCRs, etc. You can do it with the other modules and such as well - but I like knowing how my code works in these cases rather than relying on a module that doesn't know anything about TS branches.

ISCBorisB

The nice thing about this is that you can easily adjust the code...

It's platform neutral too. In *real* life I use my own code very similar to the one you've posted. It's flexibility is the very reason I've
abandoned something like dirwalk long time ago.

That said, thread Subject is "Perl method for getting files under a dir in Win32"

...does anyone have any suggestions as to which module/method exists in the default TS installation to return a list of files beneath a directory on Windows?"

nipper

I prefer to use built-in's as much as possible - and often times I just write a simple recursive function - like:
my @list;
my $start_dir = "/some/path";
process_dir($start_dir, \@list);
print "$start_dir:\n\t" , join("\n\t", @list), "\n";
exit 0;

sub process_dir {
    my($dir, $listref) = @_;
    my @subdirs;
    opendir(DIR, $dir) || die "[opendir] '$dir' ($!)";
    my @entries = grep { !/^\./ } readdir(DIR);
    closedir(DIR);
    foreach my $e (@entries){
        if (-d "$dir/$e") {
            push(@subdirs, "$dir/$e");
        }
        else {
            push(@{$listref}, "$dir/$e");
        }
    }
    process_dir($_, $listref) foreach(@subdirs);
}
The nice thing about this is that you can easily adjust the code to traverse branches without going through every edition, and/or every workarea, and/or staging (depending on your needs) and/or add additional filters to find only HTML files, or only DCRs, etc. You can do it with the other modules and such as well - but I like knowing how my code works in these cases rather than relying on a module that doesn't know anything about TS branches.

Fixing Adam's code.

I was wondering why this worked on one set of files (no subdirs) and failed on a second. I should have known it was not MY code that failed. :-)

Adam Stoller

Fixing Adam's code.

I was wondering why this worked on one set of files (no subdirs) and failed on a second. I should have known it was not MY code that failed. :-)

The operative word in my post was ".... like:" - I never said it was the exact code ;-)

Good catch.