nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

how to get the files which are attached to task

kabir123

Hi

my @files = $task->GetFiles();
I am doing these but getting no files.

Is there any other way to get the attached files of task.

Please give me suggestions.

Find more posts tagged with

Comments

moonkhanna

Hi

my @files = $task->GetFiles();
I am doing these but getting no files.

Is there any other way to get the attached files of task.

Please give me suggestions.

how are you getting $task? Please paste your complete code here.. You sure, you have files attached to the task...

kabir123

yes i m sure, as i see the attached files in teamsite gui.

use strict;
use TeamSite::WFtask;
use TeamSite::WFworkflow;
use TeamSite::Config;
use XML::XPath;
use XML::XPath::XMLParser;

my ($wfid, $taskid, $area) = @ARGV;

my $DCR_TYPE = "TeamSite/Templating/DCR/Type";
my $job = new TeamSite::WFworkflow($wfid);
my $task = new TeamSite::WFtask($taskid);
my @files = $task->GetFiles();
## CHECK FOR DCR ONLY and remove other files from array
my @files1;
foreach my $file (@files)
{
if($file =~ m/templatedata/g)
{
push (@files1, $file);
}
}
@files = @files1;

my $iw_home = TeamSite::Config::iwgethome();
my $iwmount = TeamSite::Config::iwgetmount();
$area = $iwmount . $area;
my @dcrType = ();
my @browseItems = ();
my ($dcrPath, $dctPath, $dcr, $dct, $ptvPath , $dcrname) = "";
my $error = "";

#### LOG ANY DEBUG COMMENTS
open(LOG, ">D:\\iw-home\\tmp\\generate_attach_assets_$wfid.log");
print LOG "***** Begin****\n";
print LOG "Job ID:$wfid\t Task ID:$taskid\n";
print LOG "WORKAREA:$area\n";
print LOG "DCR/files:$files[0]\n";

### CHECK IF FILE IS A DCR OR NOT
my $chkDCRCmd = `${iw_home}/bin/iwextattr -g $DCR_TYPE "$area\\$files[0]"`;
my $ret = $? >> 8;
##$ret =152 ; ### TEST BY IMRAN TO BREAK FOR ERROR ## KEEP COMMENTED ALL TIMES
print LOG "Error Code:$ret\n";
if($ret == 152)
{
print LOG "This is an invalid DCR or this file is not a DCR. Exiting this task.\n";
$task->CallBack(0,"Failed to generate. Invalid DCR or File");
exit 0;
}
elsif ( $chkDCRCmd eq "LINKnet/news") ###CHECK IF THE DCR IS OF TYPE LINKnet/news
{
print LOG "This is a valid DCR\n";
$dcr = $files[0];
}
else
{
print LOG "This File is not a valid LINKnet/news type dcr.\n";
$task->CallBack(0,"Failed to generate. Invalid DCR or File");
exit 0;
}

$dcrPath = $area . "\\" . $dcr;
$dct = $dcr;
$dct =~ s/\\data\\.*/\\datacapture.cfg/;
$dctPath = $area . "\\" . $dct;
print LOG "DCR Path:$dcrPath\n";
print LOG "DCT Path:$dctPath\n";
$ptvPath = $dcr;
$ptvPath =~ s/\\data\\.*/\\presentation\\/;
print LOG "Presentation Path:$ptvPath\n";
my $dcrSmlName = $dcr;
$dcrSmlName =~ s/templatedata\\LINKnet\\news\\data\\(.*)$/$1/;
$dcrSmlName =~ s/\\/\//g;
print LOG "DCR NAME/PATH AFTER DATA FOLDER:$dcrSmlName\n";

### CREATE AN OBJECT TO PARSE THE FILE AND FIELD XPATH QUERIES
my $xpath = XML::XPath->new( filename => "$dcrPath" );

## PRINT THE CONTENT TYPE
my $dcr_name = "//dcrName";
print LOG "DCR Name item-$dcr_name\n ";
$dcrname = $xpath->find( "$dcr_name" );
print LOG "node $dcrname node\n";

## PRINT THE CONTENT TYPE
my $element_content_type = "//newsContentType";
print LOG "Content Type item-$element_content_type\n ";
my $contentType = $xpath->find( "$element_content_type" );
print LOG "node $contentType node\n";

if ($contentType =~ m/asset/)
{
## PRINT THE ASSET LOCATION FROM THE BROWSE FIELD
my $element_asset = "//asset";
print LOG "browse item-$element_asset\n ";
my $browseLink = $xpath->find( "$element_asset" );
print LOG "node $browseLink node\n";
$error = checkAttachFile($browseLink, "Related Asset");
print LOG "Return from SUbroutine checkAttachFile-$error\n";
}

Adam Stoller

Why do you persist in keeping two identical threads going - please close one so that the information can be concentrated in the other.

kabir123

i closed the other thread.....

ISCBorisB

i closed the other thread.....

Great! Now all you have to do is

provide the actual code of the external task definition - all the attributes and sub-elements - including, especially, the actual, complete, command specification

Please try to understand. Formally your code looks more or less correct. You may have some issues with callback's but that's another story, unrelated to the attached Files.
So, the problem *seems* to be in the way you invoke this script, hence all this repeated questions

Kapish?

kabir123

hi pls find the attached workflow model and external script

kabir123

i attached the external script (attach.txt) and workflow modler(workflow.txt)

kabir123

I am calling the script from an external task .
The corresponding ipm scriptlet is attached.

The script is invoked but task files are not accessible. Task-> gatfiles() is returning none from the external called script . but the attached files are visible in previous workflow task ITeamsite UI).

Please advice.

Ghoti: hope this helps.

Antharix

Are you able to get the task id in the external script? Try writing the task id into the log from the external script.

kabir123

yes, i am getting the taskid.

kabir123

yes , i am getting the taskid. Please see the log

**** Begin ****
Job ID : 123545 Task ID: 123557
DCR\files:
Error Code : 214

kaalraa

I am calling the script from an external task .
The corresponding ipm scriptlet is attached.

The script is invoked but task files are not accessible. Task-> gatfiles() is returning none from the external called script . but the attached files are visible in previous workflow task ITeamsite UI).

Please advice.

Ghoti: hope this helps.

Can you explain the above red marked syntax as per your external script code?

Adam Stoller

i attached the external script (attach.txt) and workflow modler(workflow.txt)

Okay - you've now managed to put to rest the most likely source of the problem, which was that if you were passing parameters on the command line to your script all of the parameters you were processing in the script (code that you posted) would have been wrong and would have explained why you couldn't access the files.

( kaalraa - gatfiles is clearly a typo in the forums for GetFiles - which is shown correctly in the posted code)

The posted code shows:

...
my $job = new TeamSite::WFworkflow($wfid);
my $task = new TeamSite::WFtask($taskid);
my @files = $task->GetFiles();
...

It would be better / more correct to write it as:

...
my $job  = TeamSite::WFworkflow->new($wfid);
my $task = TeamSite::WFtask->new($taskid);
if (! $task->IsValid()) {
    # ERROR OUT HERE WITH DEBUGGING
}
my @files = $task->GetFiles();
...

You then have:

...
my @files1;
foreach my $file (@files)
{
    if($file =~ m/templatedata/g)
    {
        push (@files1, $file);
    } 
}
@files = @files1;
...

While it's not the way I'd write this code - I'd suggest you add a debugging statement directly within the foreach clause (before the 'if') so that you can see what the value of $file is each time it goes through the loop - e.g.: something like:

...
foreach my $file (@files) {
    print LOG "FILE: $file\n";
    ...
}
...

Note, you'll have to move the code that creates the log file above the foreach statement in order for this to work.

As with most code problems - if you cannot see the answer easily by looking at the code - either run it through a debugger or add a lot of debugging output so that you can see what is really happening. This is something you should do - because it is your code and your responsibility.

Antharix

If "Invalid task" is the outcome of the suggested test

if (! $task->IsValid()) {
# ERROR OUT HERE WITH DEBUGGING
}

Does it mean that there is an poblem in the TS environment? Can WFTask.pm be considered to be corrupt? if so, How can that be rectified?

kabir123

Hi ,

I did these :

my $job = TeamSite::WFworkflow->new($wfid);
my $task = TeamSite::WFtask->new($taskid);
if (! $task->IsValid()) {
print LOG "Invalid task\n";
}
if(! $job->IsValid()){
print LOG "Invalid job\n";
}
my @files = $task->GetFiles();
...

I am getting these into the LOG file:

Invalid task
Invalid job

nipper

If "Invalid task" is the outcome of the suggested test

Does it mean that there is an poblem in the TS environment? Can WFTask.pm be considered to be corrupt? if so, How can that be rectified?

Possible but IMHO, unlikely. A more likely possibility is that the task ID has been mangled somehow in perl or you are running this from the DOS shell (or not a WF) and the task ID being passed is either wrong or missing.

nipper

Hi ,

I did these :

my $job = TeamSite::WFworkflow->new($wfid);
my $task = TeamSite::WFtask->new($taskid);
if (! $task->IsValid()) {
print LOG "Invalid task\n";
}
if(! $job->IsValid()){
print LOG "Invalid job\n";
}
my @files = $task->GetFiles();
...

I am getting these into the LOG file:

Invalid task
Invalid job

print out $taskid and $wfid to your log, as well as all command line parameters you are receiving.

moonkhanna

also try getting your arguments like the below instead of what you are doing right now -

my ($wfid, $taskid, $area) = (@ARGV[0..2]);

Adam Stoller

also try getting your arguments like the below instead of what you are doing right now -

my ($wfid, $taskid, $area) = (@ARGV[0..2]);

You don't need to specify the slice - Perl will only populate the number of variables specified on the left-hand side - plus I generally recommend retrieving the area from the task object, once it is created, rather than pulling it in from the command line arguments:

my ($wfid, $taskid) = @ARGV;
...create task object...
my $area = $task->GetArea();
...

The real benefit of this comes when you're trying to debug the script by running it from the command line (with a given task active) - you only need to provide jobid and taskid when you do so and not worry about getting the path to the workarea correct. i.e.:[indent]iwperl -d myscript.ipl 1234 1238[/indent]instead of:[indent]iwperl -d myscript.ipl 1234 1238 /default/main/someLong/and/ComplexBranchName/WORKAREA/someStrangeWAname[/indent]

moonkhanna

You don't need to specify the slice - Perl will only populate the number of variables specified on the left-hand side - plus I generally recommend retrieving the area from the task object, once it is created, rather than pulling it in from the command line arguments:
my ($wfid, $taskid) = @ARGV;
...create task object...
my $area = $task->GetArea();


...
The real benefit of this comes when you're trying to debug the script by running it from the command line (with a given task active) - you only need to provide jobid and taskid when you do so and not worry about getting the path to the workarea correct. i.e.:[indent]iwperl -d myscript.ipl 1234 1238[/indent]instead of:[indent]iwperl -d myscript.ipl 1234 1238 /default/main/someLong/and/ComplexBranchName/WORKAREA/someStrangeWAname[/indent]

Hi Adam,

Yes, this would be better to do.. I also believe the slice wouldnt be necessary but just in case...

Best Regards,

Munish Khanna

moonkhanna

Kabir123,

Another thing here would be if you are passing some parameter to the ipl.. then this parameter is the first one to go, which means you would actually get wrong values for your defined variables..