nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

if condition doesn't work on TS 6.7.1

aby_sam

We are migrating our contents from TS 6.1 AIX to TS 6.7.1 SP1 RH linux.
The following code snippet doesn't work after the migration to linux.

if($^O eq "MSWin32") { $selectedpath =~ s!^$iwmount\\default\\main\\.*\\WORKAREA\\[^\\]+\\!!; }
else { $selectedpath =~ s!^$iwmount/default/main/.*/WORKAREA/[^/]+/!!; }

Can someone tell me the reason for $selectedpath returning no value in linux:

Thanks in advance.

Find more posts tagged with

Comments

Adam Stoller

We are migrating our contents from TS 6.1 AIX to TS 6.7.1 SP1 RH linux.
The following code snippet doesn't work after the migration to linux.

if($^O eq "MSWin32") { $selectedpath =~ s!^$iwmount\\default\\main\\.*\\WORKAREA\\[^\\]+\\!!; }
else { $selectedpath =~ s!^$iwmount/default/main/.*/WORKAREA/[^/]+/!!; }

Can someone tell me the reason for $selectedpath returning no value in linux:

Thanks in advance.

Do you know if $selectedpath has no value, or that it might have a value that doesn't match the regex?

How is $selectedpath getting set?

aby_sam

Thanks Ghoti.
The $selectedpath has no value

Adam Stoller

Thanks Ghoti.
The $selectedpath has no value

Okay - but where in the script is it supposed to be getting a value? You've only shown where the value was tested not where it originated.

aby_sam

Here is the full section of code:

# TS directories
my $iwhome = TeamSite::Config::iwgethome();
my $iwmount = TeamSite::Config::iwgetmount();

my $cgi = new CGI;

# TS GUI parameters, for a complete list of available variables,
# please refer to the TeamSite administration guide
my $area_path = $cgi->param("area_path");
my $user_name = $cgi->param("user_name");
my $user_role = $cgi->param("user_role");
my $vpath = $cgi->param("vpath");

# user selected files are stored as hashes in the @selectedhash array
my $pcount=0;
my $selectedpath;
my @selectedhash;

my $dcrParserObj;

while($selectedpath = $cgi->param("path_$pcount"))
{
# strip out path in front of workarea vpath, so files are relative to workarea
#if($^O eq "MSWin32") { $selectedpath =~ s!^$iwmount\\default\\main\\.*\\WORKAREA\\[^\\]+\\!!; }
#else { $selectedpath =~ s!^$iwmount/default/main/.*/WORKAREA/[^/]+/!!; }

my $selectedtype = $cgi->param("type_$pcount");
my $selectedname = $cgi->param("name_$pcount");

my $hash;
$hash->{"type"} = $selectedtype;
$hash->{"path"} = $selectedpath;

push @selectedhash, $hash;
$pcount++;
}

ISCBorisB

Here is the full section of code:

# TS directories
my $iwhome = TeamSite::Config::iwgethome();
my $iwmount = TeamSite::Config::iwgetmount();

my $cgi = new CGI;

# TS GUI parameters, for a complete list of available variables,
# please refer to the TeamSite administration guide
my $area_path = $cgi->param("area_path");
my $user_name = $cgi->param("user_name");
my $user_role = $cgi->param("user_role");
my $vpath = $cgi->param("vpath");

# user selected files are stored as hashes in the @selectedhash array
my $pcount=0;
my $selectedpath;
my @selectedhash;

my $dcrParserObj;

while($selectedpath = $cgi->param("path_$pcount"))
{
# strip out path in front of workarea vpath, so files are relative to workarea
#if($^O eq "MSWin32") { $selectedpath =~ s!^$iwmount\\default\\main\\.*\\WORKAREA\\[^\\]+\\!!; }
#else { $selectedpath =~ s!^$iwmount/default/main/.*/WORKAREA/[^/]+/!!; }

my $selectedtype = $cgi->param("type_$pcount");
my $selectedname = $cgi->param("name_$pcount");

my $hash;
$hash->{"type"} = $selectedtype;
$hash->{"path"} = $selectedpath;

push @selectedhash, $hash;
$pcount++;
}

That's classical infinite loop sample. Your thread never leaves while($selectedpath...) block.

Sooner or later path_0, path_1, ... path_N List gets exausted and $selectedpath is undefined - for every subsequent $pcount value (till perhaps
"Arithmetic Overflow" Error on the $pcount++; Command). Btw, unless I miss sometning here what does any of that have to do to "if" functionality?

Adam Stoller

That's classical infinite loop sample. Your thread never leaves while($selectedpath...) block.

Sooner or later path_0, path_1, ... path_N List gets exausted and $selectedpath is undefined - for every subsequent $pcount value (till perhaps
"Arithmetic Overflow" Error on the $pcount++; Command). Btw, unless I miss sometning here what does any of that have to do to "if" functionality?

I would think the issue is different - the path_# form variables are "old" form variables (5.x and earlier) - 6.x will not create those variables unless you are wrapping the call to your script through wdpro_menu.ipl.

I suggest you implement a Show Env custom menu item (running show_env.ipl) and take a look - a lot has probably changed since this code was written.

ISCBorisB

I would think the issue is different - the path_# form variables are "old" form variables (5.x and earlier) - 6.x will not create those variables unless you are wrapping the call to your script through wdpro_menu.ipl.

I suggest you implement a Show Env custom menu item (running show_env.ipl) and take a look - a lot has probably changed since this code was written.

The way it's coded it's an infinite loop regardless. In 6.x $selectedpath is then simply undefined from the very beginning - and the loop goes on.
In 5.x it is undefined from oh say 7 - and looping goes on ad infinitum still

Adam Stoller

The way it's coded it's an infinite loop regardless. In 6.x $selectedpath is then simply undefined from the very beginning - and the loop goes on.
In 5.x it is undefined from oh say 7 - and looping goes on ad infinitum still

It is not an endless loop

while($selectedpath = $cgi->param("path_$pcount")) { ... }

According to the perldoc:[indent]FETCHING THE VALUE OR VALUES OF A SINGLE NAMED PARAMETER:

@values = $query−>param('foo');

−or−

$value = $query−>param('foo');

Pass the param() method a single argument to fetch the value of the named parameter. If the parameter is multivalued (e.g. from multiple selections in a scrolling list), you can ask to receive an array. Otherwise the method will return a single value.

If a value is not given in the query string, as in the queries "name1=&name2=" or "name1&name2", it will be returned as an empty string. This feature is new in 2.63.

[color=red]If the parameter does not exist at all, then param() will return undef in a scalar context, and the empty list in a list context.[/color][/indent]A while loop will exit if the test condition results in undef - try the following:

my @list = ("a", "b", undef, "c");
while (my $x = shift(@list)) {
    print "X: $x\n";
}
print "DONE\n";

On my laptop, this results in:

X: 'a'
X: 'b'
DONE

However, as I stated in my previous response, if the variable doesn't exist, then $selectedpath will be undef / have no value - and thus the code

$selectedpath =~ s!^$iwmount/default/main/.*/WORKAREA/[^/]+/!!;

will also have no value. The 'if' test is working just fine - it's the value it is supposed to be processing that's wrong.

Chances are, if you rummage through the various log files - somewhere you'll see something like:[indent]Use of uninitialized value in substitution (s///) at ....[/indent]which is the result of trying to do a regex operation on an undefined value ($selectedpath)

ISCBorisB

It is not an endless loop...

Ah, yes. My mistake, thanks

aby_sam

Ghoti is right. This code was initially written for TS 5.5.2. It works good on TS 6.1. But in 6.7.1 SP1 it breaks.

The following is uncommented in my earlier post. sorry for that mistake.

if($^O eq "MSWin32") { $selectedpath =~ s!^$iwmount\\default\\main\\.*\\WORKAREA\\[^\\]+\\!!; }
else { $selectedpath =~ s!^$iwmount/default/main/.*/WORKAREA/[^/]+/!!; }

Adam Stoller

Ghoti is right. This code was initially written for TS 5.5.2. It works good on TS 6.1. But in 6.7.1 SP1 it breaks.

So - do you understand the path (slight pun intended) to take in fixing it?