add function in tpl, but it can't run

after added new function in the tpl file, the new form is created can't be save.
would you help for reviewing my code in blew:

my ($sMetaKeywords, $sMetaDescription);
my ($sMetaKeywordsfile, $sMetaDescriptionfile);

if (iwpt_dcr_list("dcr.main.metatags.metamanual") ne 0) {
$sMetaKeywords = iwpt_dcr_value("dcr.main.metatags.metamanual.metakeywords");
$sMetaDescription = iwpt_dcr_value("dcr.main.metatags.metamanual.metadescription");
}
else {
$sMetaKeywordsfile = iwpt_dcr_value("dcr.main.metatags.metafiles.metadescriptionfile");
$sMetaDescriptionfile = iwpt_dcr_value("dcr.main.metatags.metafiles.metakeywordfile");

open(FH_KW, "$sMetaKeywordsfile")
$sMetaKeywords = do { local $/; ; };
close(FH_KW);

open(FH_DS, "$sMetaDescriptionfile")
$sMetaDescriptionfile = do { local $/; ; };
close(FH_DS);

}

Find more posts tagged with

Comments

Glass

i think the error in

open(FH_KW, "$sMetaKeywordsfile")
$sMetaKeywords = do { local $/; ; };
close(FH_KW);

open(FH_DS, "$sMetaDescriptionfile")
$sMetaDescriptionfile = do { local $/; ; };
close(FH_DS);

but i don't know how to modify it, would you mind correct it for me? thanks

Adam Stoller

i think the error in

open(FH_KW, "$sMetaKeywordsfile")
$sMetaKeywords = do { local $/; ; };
close(FH_KW);

open(FH_DS, "$sMetaDescriptionfile")
$sMetaDescriptionfile = do { local $/; ; };
close(FH_DS);

but i don't know how to modify it, would you mind correct it for me? thanks

Note - that's the forum interpreting improperly formatted code - the actual code is:

...
  open(FH_KW, "$sMetaKeywordsfile")
  $sMetaKeywords = do { local $/; <FH_KW>; };
  close(FH_KW);

  open(FH_DS, "$sMetaDescriptionfile")
  $sMetaDescriptionfile = do { local $/; <FH_DS>; };
  close(FH_DS);
...

True - there should be testing done to ensure that the file actually opened - however, going back to the original statement:

after added new function in the tpl file, the new form is created can't be save.

The question is what do you mean by "created can't be save"?

Modifying a PT should have no affect on whether or not the DCR can be saved. It might, however, have an affect on whether a page can be generated from the DCR.

So - perhaps you can provide a bit more clarification on what problem you are having and where the problem is manifesting itself.

Glass

thanks your reply.
i think the error is in:
$sMetaKeywordsfile="C:\somepath\test\test.asp"
$sMetaKeywordsfile= ~ s/\\/\//;

i can't replace the '\' to '/'

the "created can't be save" means: after i click file->new form entry, and input some info in it, i can't save(i think it can't generate DCR).

would you train me about it? thanks

Adam Stoller

thanks your reply.
i think the error is in:
$sMetaKeywordsfile="C:\somepath\test\test.asp"
$sMetaKeywordsfile= ~ s/\\/\//;

i can't replace the '\' to '/'

the "created can't be save" means: after i click file->new form entry, and input some info in it, i can't save(i think it can't generate DCR).

would you train me about it? thanks

Response / explanation posted HERE

new_report_1.rptdesign

duke

thanks your instruction.
i try your code($sMetaKeywordsfile =~ tr|\\|/| Smiley Wink

the result is ("C:somepath est est.asp")
it is same as my code( $sMetaKeywordsfile =~ s/\\/\// Smiley Wink

would you help me?

ISCBorisB

thanks your instruction.
i try your code($sMetaKeywordsfile =~ tr|\\|/|
the result is ("C:somepath est est.asp")
it is same as my code( $sMetaKeywordsfile =~ s/\\/\//

would you help me?

That's because your original variable assignment is incorrect. In Perl expression in double quotes gets evaluated, so escape symbol '\'
actually has semantics. For example, \t is Tab, etc. So, modify as follows

#$sMetaKeywordsfile="C:\somepath\test\test.asp";	# Incorrect, Commented out
$sMetaKeywordsfile = qq(C:\\somepath\\test\\test.asp);	# Recommended Syntax. Note escaped "reverse slash" delimiter ###OR###
$sMetaKeywordsfile = "C:\\somepath\\test\\test.asp";	# Same as above, "quoted" form, ###OR###
$sMetaKeywordsfile = 'C:\somepath\test\test.asp';	# Note Single Quotes!