Inlinelink doesn't seem to be using my custom style sheet

Eric Borisow

Hi,

I'm using Inline links (vgn-ext-links) with Workspace Extensions and VCM 8.0.2.  I am using the jsp that comes with vgn-ext-links in the parameter for my ephox widget and also adding a custom style sheet.  It's supposed to pick up the styles from the custom css and add it into the ephox editor.  Unfortunately, it's not working.  I don't see any of the styles from the css in the editor.  In v7, you could see the stylesheet parameter getting passed in the debug messages for ephox, but I'm not seeing it in v8.  Does anyone know of a way that I can try to debug this to see if it's actually reading the custom style sheet property?

Thanks,

Eric

Eric Borisow

Hi,

I found the problem, so I'm just posting in case someone else runs into the same issue.  It seems to be a bug in the vgn-ext-links of the Workspace Extensions.  Here is what I found.  First, in the vign-elj-config.jsp, there is code to pull the styleSheetLink parameter from the current request.

String styleSheet = request.getParameter("styleSheetLink");

So, the jsp is looking for that parameter.  In our older version of vgn-ext-links (inlinelinks), the stylesheet would create the configuration URL for ephox like this:

editlive_<xsl:value-of select="$n"/>.setConfigurationFile("<xsl:value-of select="normalize-space($elConfigurationFile)"/>?coeFieldName=<xsl:value-of select="$n"/>&amp;styleSheetLink=<xsl:value-of select="$styleSheet"/>");

In that URL, you can see that the styleSheetLink is passed as a parameter.

In the vgn-ext-links, it looks like setConfigurationFile was abandoned for setConfigurationText (for performance reasons - setConfigurationText loads faster).

editlive_<xsl:value-of select="$n"/>.setConfigurationText("<xsl:value-of select="$configText"/>");

Unfortunately, it doesn't pass the styleSheetLink to the jsp page.  So, if you specify a custom stylesheet in the widget, it won't get passed.  So, we modified the xsl to continue to use setConfigurationText, but it will incorporate the stylesheet, if it's passed.

<xsl:choose>     <xsl:when test="string-length($styleSheet) != 0">      <!-- Here we are passing the styleSheetLink parameter to the underlying jsp file -->      <xsl:variable name="customConfigFile" select="concat($elConfigurationFile, '?styleSheetLink=', $styleSheet)" />      <xsl:variable name="configText" select="java:com.vignette.goe.utils.ELJUtils.getELJConfigText($customConfigFile, $n, $styleSheet)"/>      editlive_<xsl:value-of select="$n"/>.setConfigurationText("<xsl:value-of select="$configText"/>");     </xsl:when>     <xsl:otherwise>      <xsl:variable name="customConfigFile" select="$elConfigurationFile" />      <xsl:variable name="configText" select="java:com.vignette.goe.utils.ELJUtils.getELJConfigText($customConfigFile, $n, $styleSheet)"/>      editlive_<xsl:value-of select="$n"/>.setConfigurationText("<xsl:value-of select="$configText"/>");     </xsl:otherwise>      </xsl:choose>

So, it will basically just add the styleSheetLink parameter if the stylesheet is available.

Regards,

Eric