nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Passing value from subroutine

becool321

Hey guys,

I keep getting null value (for $valuewidth) whenever I try to retrieve a value into a subroutine(outputImage) originating from another subroutine(outputWidth) in a presentation template. See code below for passing and receiving subroutine:

sub outputWidth($$;$) {
my $value = $_[0];
my $tag = $_[1];
my $attribute = "";
$attribute = " $_[2]" if $_[2];
my $valuewidth = $_[3];

if ($value) {
$value =~ s#
# #g; # Remove HTML breaks
$value =~ m/&/&/g;
$value =~ m/>/>/g;
$value =~ m/
iwpt_output(" <$tag$attribute><" . "![CDATA[$value]]" . ">\n");

$valuewidth=$value;

return $valuewidth;

iwpt_output(" <$tag$attribute><" . "![CDATA[$value]]" . ">\n");

}

} # End of sub outputWidth($$;$) {

sub outputImage($$;$) {

my $valuewidth=outputWidth($valuewidth);

my $width="width";
my $value = $_[0];
my $tag = $_[1];
my $attribute = "";
$attribute = " $_[2]" if $_[2];

iwpt_output(" <$tag$attribute $width='$valuewidth' >\n");
}

} # End of sub outputImage($$;$) {

Find more posts tagged with

Comments

Adam Stoller

The code you posted is invalid and potentially flawed in other respects.

You have an extra close-curly-brace in your outputImage subroutine, you declare parameters for your subroutines (generally not recommended), and then seem to process more parameters than you declare, you seem to needlessly use concatenator operators where you could just use one string, and you have code following a return statement in outputWidth subroutine.

... and you didn't verify that your code could be properly viewed in the forums.

becool321

Thanks Ghoti for your feed back, I have made the corrections from my cut and paste errors. Here is correct code:

sub outputWidth($$;$) {
my $value = $_[0];
my $tag = $_[1];
my $attribute = "";
$attribute = " $_[2]" if $_[2];
my $valuewidth = $_[3];

$valuewidth=$value;

if ($valuewidth) {
$valuewidth =~ s#
# #g; # Remove HTML breaks
$valuewidth =~ m/&/&/g;
$valuewidth =~ m/>/>/g;
$valuewidth =~ m/
iwpt_output(" <$tag$attribute>\n");

return $valuewidth;

}

} # End of sub outputWidth($$;$) {

sub outputImage($$;$) {

my $width="width";
my $height="height";
my $value = $_[0];
my $tag = $_[1];
my $attribute = "";
$attribute = " $_[2]" if $_[2];
my $valuewidth = $_[3];

my $valuewidth=outputWidth($valuewidth);

iwpt_output(" <$tag$attribute $width='$valuewidth'>\n");

} # End of sub outputImage($$;$) {

The code actually works part way. If you make

my $valuewidth='9';

value is shown at

$width='$valuewidth'

but I can't get previous value(return $valuewidth Smiley Wink

from my sub outputWidth to appear in:

$valuewidth in output below:

iwpt_output(" <$tag$attribute $width='$valuewidth'>\n");

I keep getting no value as seen in actual output here:

(image width="" /)

I think this part of my code below is incorrect which(value not retrieving from previous sub) I have been trying greatly to correct:

my $valuewidth=outputWidth($valuewidth);

Adam Stoller

You still declare parameters for your subroutines (generally not recommended), and then seem to process more parameters than you declare, and you didn't verify that your code could be properly viewed in the forums.

You have also not verified (or stated as much) that your code compiles cleanly with '-w -c' flags - for instance, I think this:

$valuewidth =~ m/>/>/g;

Might need to be:

$valuewidth =~ m/>/&\#x3E;/g;

So much for the easy code critique.

I don't know how you're calling outputImage() nor where you're getting the arguments to pass it - but that routine calls outputWidth() - with only one argument, instead of the two that it is scoped for, or the four that it seems to want to process - and it clearly calls iwpt_output() in addition to returning some string - and, well, quite simply, I don't see how this code could possibly work as-is and I think you need to spend a bit more time working on it.

becool321

Ok Ghoti here all the files. The compile error occured even before I started to work on this, I copied to adjust output according to business requirements. I'm trying to get the value 195 as seen in output to show in image width=''. After which I'll be able to pupulate other areas accordingly. Thanks for helping.

Adam Stoller

Ok Ghoti here all the files. The compile error occured even before I started to work on this, I copied to adjust output according to business requirements. I'm trying to get the value 195 as seen in output to show in image width=''. After which I'll be able to pupulate other areas accordingly. Thanks for helping.

You can probably get rid of the CDATA block that is immediately within the iw_perl block.
If you can get rid of the XML-style PT code at the bottom of your PT, you could temporarily comment out the iw_perl tags and test-compile the perl code with the '-w -c' flags (you cannot do that with the XML code in there - as Perl (the engine) doesn't know anything about XML code - hence some of the errors you are currently seeing in your error.txt file

I'm not sure you really need the CDATA tag within your outputXxx functions - but that's neither here nor there at this point. As long as you make sure that '&' is replaced with '&' the title shown in your output.txt file should work fine. Frankly, you could probably use a single call to HTML::Entities' encode_entities() method to take care of this for you instead of repeating the same series of regex's all over the place in your code.

So - I think you need to do more debugging on your end, probably do some re-writing / re-implementing - I'm not sure I want to spend too much more of my "free time" debugging your code for you.

becool321

Thanks Ghoti, I got it working, I eliminated the redundant code using code only once where possible.

Adam Stoller

Thanks Ghoti, I got it working, I eliminated the redundant code using code only once where possible.

For the benefit of the forum, perhaps you could post the resultant PT code (either properly wrapped within [html]...[/html] block, or as an attachment) - and then close the thread as being resolved.