nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Perl Questions for TPL

nirjari

[html]
 ########## perl modules ############ use TeamSite::Config; use OLG::tpl_utils; use OLG: Smiley Surprised

penDeploy; ########## perl modules ############ my $iwhome = TeamSite::Config::iwgethome(); my $iwmount = TeamSite::Config::iwgetmount(); ($iwcfg) = "$iwhome/bin/iwconfig"; my $dcrpath = iwpt_get_dcr_name(); $dcrpath =~ s#\.iwmnt#iwmnt#g; my $dcr_name = iwpt_get_dcr_name("basename"); my $prefix = getLOB($dcrpath); my $prefDir = uc($prefix); my $templatename = getDataType($dcrpath); my $contentname = $dcr_name; $dcrpath =~ m/\/([^\/]+)\/data/; my $ofile = "generated/component/".$templatename."/".$prefix."_".$contentname.".xml"; (my $hostname = `$iwcfg iwwebd host`) =~ s#\n$##; my $edit_path = "http://".$hostname."/iw-cc/edit?vpath=".$dcrpath; $edit_path =~ s#$iwmount##g; (my $bellca = `$iwcfg iwwebd bellca`) =~ s#\n$##; my $endtag = "]"."]>"; my $cdata = "<!"."[CDATA["; ############ Build the initial media lists my @media_ids = (); my $filelist = 'generated/filelist/'; my $media_file = $filelist.$prefix."_".$contentname."_images.txt"; my @matches = getImageList( iwpt_get_dcr_name() ); ############ Build the region array my @region_array = ("default"); my $item_region = join(',',@region_array); ############ 
[/html]

In this code, "use CGI" is not used. So how will the progrma understand the environment variables ?

variable is defined as ($iwcfg) , why do we need bracket around variable name, what does it do ? There are my variables declred with brackets as well. So what does it do when there are brackets around variable name ?

Whats the point in declaring my variables at the top level in program. Since my variables are used for localalization of the sciope, why is it at the top ?

Whats the point in declaring "$dcrpath" and "my $dcrpath" at the same level ? Are they different from each other ?

Find more posts tagged with

Comments

nipper

In this code, "use CGI" is not used. So how will the progrma understand the environment variables ?

use CGI has no effect on environment variables.

variable is defined as ($iwcfg) , why do we need bracket around variable name, what does it do ? There are my variables declred with brackets as well. So what does it do when there are brackets around variable name ?

It makes no difference if you have only one variable there.

If you have multiple variables to define, you can do it an once

my ($var, $number2, $number3);

Whats the point in declaring my variables at the top level in program. Since my variables are used for localalization of the sciope, why is it at the top ?

Best practice, if you have a variable that is used throughout the script, declare it at the top

Whats the point in declaring "$dcrpath" and "my $dcrpath" at the same level ? Are they different from each other ?

You are not declaring dcrpath at the same level,

one declares it, the other changes it via =~ s....

That is a regex

BTW, when you see a red line underneath a word in your post, that means it is not spelled correctly and you may and to fix it.

vpatel

Take a look at this link.

ISCBorisB

Andy, you must have been very bored...

nipper

Andy, you must have been very bored...

quite, and still sober, unlike now.

Adam Stoller

I'm bored too, so I'll hit on some points that Nipper didn't:

<iw_perl>
<![CDATA[
...
]]>
</iw_perl>

At the beginning and end of your PT - you probably have something like:

<iw_pt name="...">
...
</iw_pt>

If you remove the closing tag and either remove, or change the opening tag to:

<iw_pt name="..."/>

You can get rid of the CDATA tags, which tends to make the code more intelligible.

########## perl modules ############
use TeamSite::Config;
use OLG::tpl_utils;
use OLG:penDeploy;
########## perl modules ############
my $iwhome  = TeamSite::Config::iwgethome();
my $iwmount = TeamSite::Config::iwgetmount();

($iwcfg) = "$iwhome/bin/iwconfig";

Unless

$iwcfg

is declared in one of the custom

OLG::*

modules, the last line above should be:

my $iwcfg = "$iwhome/bin/iwconfig";

No, you do not need the parens (as Nipper already pointed out), but you should declare the variable.

I recommend that you should also include the following pragmas at the top:

use strict;
use warnings;

This will help uncover issues with your code that might otherwise go unnoticed by the Perl engine, but cause strange behavior when the code is run.

There are some cases (I seem to recall it was with one of the workflow modules) where you cannot use one or the other of these modules due to some broken code in ... one of those modules ... but that's rare and usually (if I remember correctly) only in CGI code.

$dcrpath =~ m/\/([^\/]+)\/data/;

This is useless code. It's a match test being used without the conditionals (if) and the value being stored in the registry variable (

$1 = ([^\/]+)

) is not used anywhere else in the code - so you should either figure out why the test is needed and fix the code accordingly, or just remove this line completely.

my $ofile = "generated/component/".$templatename."/".$prefix."_".$contentname.".xml";
...
my $edit_path = "http://".$hostname."/iw-cc/edit?vpath=".$dcrpath;
...
my $media_file = $filelist.$prefix."_".$contentname."_images.txt";

I see examples of this in so much code and, IMO, it makes the code more obfuscated than it needs to be. Compare the above to the below, which does the same thing, and see which you think is easier to read:

my $ofile = "generated/component/$templatename/${prefix}_$countentname.xml";
...
my $edit_path = "http://$hostname/iw-cc/edit?vpath=$dcrpath";
...
my $media_file = "$filelist${prefix}_${contentname}_images.txt";

You only need the curly braces surrounding the variable name if the variable name is immediately followed by a character that could be confused as being part of the variable name (in this case, the underscore).

That's about it for my portion of critique corner - have fun :-)