nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Simple code causing TS not to save DCR?

dchristie

TS 6.7.2
Solaris

We have a DCR that we have added a couple of new javascript functions to do some simple math, applying a discount to a price and then putting the result into a hidden field. If the DCR is opened and nothing is touched the DCR can be saved with no problem. But if the functions are triggerd, done by entering text into the discount or price fields, then we cannot save the DCR and receive some errors. The errors are in the servletd_out.log associated with an Error reading DTD dcr4.5.dtd. also, the DCR throws an error to UI that says "Save was unsuccessful. Invalid category/type null was received."

We have a support ticket open with Interwoven open 5 weeks now with no luck. I've sent them a stripped down simplified version of the DCT and they are encoutering the same issue.

Has anyone encoutered a simple function firing causing a DCT not to save? Looking for some ideas. I've attached the simplified DCT. Thanks.

Find more posts tagged with

Comments

Rick Poulin

What's the real error message? Usually the error box has a "details" button.

In my experience, the error you're getting is usually caused by custom Javascript that throws errors (e.g. syntax errors) before the onFormInit handler gets called. I suggest making sure your Javascript is valid.

IDM.xlsx

dchristie

What's the real error message? Usually the error box has a "details" button.

In my experience, the error you're getting is usually caused by custom Javascript that throws errors (e.g. syntax errors) before the onFormInit handler gets called. I suggest making sure your Javascript is valid.

You get different errors depending if you are trying to "save as" the DCR versus trying to do Preview or Save on an existing DCR.

- The Save As on a new DCR gives an object error in the browser:" Line 11, Object doesn't support this property or method "

- On a Preview of an existing DCR you get a TS window error: "Please select a form entry"

- And on a basic Save on an existing DCR you get a TS window error:
"Save was unsuccessful. Invalid category/type null was received."

If the Java Script is not triggerd the DCR saves just fine. I would think it could be a syntax error, but I'm just not seeing if it is.

ISCBorisB

...You get different errors depending...

- Here is your cardinal sin - an attempt to set DCR Item's true numeric value. That's what kills "Save".
Convert it to the String. Like this:

function setValue(name, value) {
IWDatacapture.getItem(parent + name).setValue(value + '');
}

Other than that you have tons of problems with this code. Most obvious:

- Unless specifically documented, you should never run anything directly from the Script
like you do for init_link_to(). It is way too early. You must create your own init function(s)
and run them onFormInit Event. To register "onFormInit" you must use "addFormHandler".
Both Manuals and Forum have samples

- Your "addItemHandler" lines should be within the init() function.

- You should never register same handlers over and over again like you (potentially) do within
init_link_to on replicant add

- You should not register event Handlers for each replica, only one per Replicant Container/Item

and so on...

dchristie

- Here is your cardinal sin - an attempt to set DCR Item's true numeric value. That's what kills "Save".
Convert it to the String. Like this:

function setValue(name, value) {
IWDatacapture.getItem(parent + name).setValue(value + '');
}

Other than that you have tons of problems with this code. Most obvious:

- Unless specifically documented, you should never run anything directly from the Script
like you do for init_link_to(). It is way to early. You must create your own init function(s)
and run them onFormInit Event. To register "onFormInit" you must use "addFormHandler".
Both Manuals and Forum have samples

- Your "addItemHandler" lines should be within the init() function.

- You should never register same handlers over and over again like you (potentially) do within
init_link_to on replicant add

- You should not register event Handlers for each replica, only one per Replicant Container/Item

and so on...

Thanks for the help! It's working now. I'm able to save with no errors. The changing of the setValue to setValue + '' did the trick for the saving issue. And I've cleaned up the init functions to run cleaner. Apprecaite it!

Question about your last recommendation about the Handlers for each replica. If not addressing down to the container/replicant/field level how would we know that there is an onItemchange to a particular field in a child of replicant in the container?

Cost_datadesign.zip

ISCBorisB

Question about your last recommendation about the Handlers for each replica...

I was talking about something like that: IWEventRegistry.addItemHandler(parent + "/whatever", "onItemChange", ...);
called on every "Replicant Added" Event. Whatever "parent" Object here is, that's not how you do these things.

For the "onItemChange" you do go down to the field level. Thing is, you set it only once ignoring replicas' ordinal
numbers. Note that FormAPI will automatically pass a reference of the Item Object that triggered the Change Event
to your Event Handler. You can manipulate it directly without ever knowing what nested Ordinal Numbers are there.
If you need an access to the trigger's related Items you'd have to get trigger Item's XPath and go from there.

Makes sense?

dchristie

I was talking about something like that: IWEventRegistry.addItemHandler(parent + "/whatever", "onItemChange", ...);
called on every "Replicant Added" Event. Whatever "parent" Object here is, that's not how you do these things.

For the "onItemChange" you do go down to the field level. Thing is, you set it only once ignoring replicas' ordinal
numbers. Note that FormAPI will automatically pass a reference of the Item Object that triggered the Change Event
to your Event Handler. You can manipulate it directly without ever knowing what nested Ordinal Numbers are there.
If you need an access to the trigger's related Items you'd have to get trigger Item's XPath and go from there.

Makes sense?

Hmmm, not quite. Here's the code I'm toying with now if I'm following what your saying, but it's not working. I've commented out the items in HasChildrengetaways_group:

var parent = '' ;

IWEventRegistry.addFormHandler("onFormInit", init);

function init() {
// Add event handlers
IWEventRegistry.addItemHandler(parent + "/general/offset", "onItemChange", update_offset_price );
IWEventRegistry.addItemHandler(parent + "/getaways_group/getaways", "onItemChange", gw_change );
init_link_to( parent );
}

function init_link_to( parent )
{
// Determine if there is children on defined containers

var HasChildrengetaways_group= false;
var HasChildrendestination_list = false;

if ((IWDatacapture.getItem("/getaways_group").getChildren() != null) && (IWDatacapture.getItem("/getaways_group/").getChildren().length >= 1))
{

HasChildrengetaways_group= true;
}
else
{

HasChildrengetaways_group= false;
}

if (HasChildrengetaways_group)
{
// IWEventRegistry.addItemHandler(parent + "/getaways_group/getaways/w_rate1", "onItemChange", gw_wrate1_change );
// IWEventRegistry.addItemHandler(parent + "/getaways_group/getaways/w_rate1_discount", "onItemChange", gw_wrate1_discount_change );

}

IWDatacapture.redraw() ;
}

function gw_wrate1_change (item)
{

var index = item.getName() ;
index = index.substring( index.indexOf( '[' ) + 1 , index.indexOf( ']' ) ) ;
alert(item.getName());
alert(getValue( "/getaways_group/getaways[" + index + "]/w_rate1" ) - getValue( "/general/offset" ));
setValue( "/getaways_group/getaways[" + index + "]/gold_w_rate1" , getValue( "/getaways_group/getaways[" + index + "]/w_rate1" ) - getValue( "/general/offset" ) ) ;
alert(getValue( "/getaways_group/getaways[" + index + "]/gold_w_rate1"));

}

function gw_change (item)
{
alert("Im here");
var index = item.getName() ;
index = index.substring( index.indexOf( '[' ) + 1 , index.indexOf( ']' ) ) ;
alert(item.getName());
alert(getValue( "/getaways_group/getaways[" + index + "]/w_rate1" ) - getValue( "/general/offset" ));
setValue( "/getaways_group/getaways[" + index + "]/gold_w_rate1" , getValue( "/getaways_group/getaways[" + index + "]/w_rate1" ) - getValue( "/general/offset" ) ) ;
alert(getValue( "/getaways_group/getaways[" + index + "]/gold_w_rate1"));

}

function gw_wrate1_discount_change (item)
{

var index = item.getName() ;
index = index.substring( index.indexOf( '[' ) + 1 , index.indexOf( ']' ) ) ;
alert(item.getName());
alert(getValue( "/getaways_group/getaways[" + index + "]/w_rate1_discount" ) - getValue( "/general/offset" ));
setValue( "/getaways_group/getaways[" + index + "]/gold_w_rate1_discount" , getValue( "/getaways_group/getaways[" + index + "]/w_rate1_discount" ) - getValue( "/general/offset" ) ) ;
alert(getValue( "/getaways_group/getaways[" + index + "]/gold_w_rate1_discount"));

}

function getValue( name )
{
return IWDatacapture.getItem( parent + name ).getValue() ;
}
function setValue( name , value )
{
IWDatacapture.getItem( parent + name ).setValue( value + '') ;
}

function update_offset_price( item )
{
alert('entering function' );
var index = item.getName() ;
alert('name: ' + item.getName() );

// loop through getaways_group container
var array1 = IWDatacapture.getItem( "/getaways_group/getaways" ).getChildren() ;
alert('array1: '+ array1.length);

for( var i = 1 ; i <= array1.length ; i++ )
{
alert('value of index ' + i);
setValue( "/getaways_group/getaways[" + i + "]/gold_w_rate1" , getValue( "/getaways_group/getaways[" + i + "]/w_rate1" ) - getValue( "/general/offset" ) ) ;
setValue( "/getaways_group/getaways[" + i + "]/gold_w_rate1_discount" , getValue( "/getaways_group/getaways[" + i + "]/w_rate1_discount" ) - getValue( "/general/offset" ) ) ;

}

}

ISCBorisB

As I indicated before - you have plenty of problems with this code.

I'll point few obvious issues and leave you to fix it
- DCT Structure is overcomplicated. Although replicant Items are still supported
they are ancient. Use replicant containers instead, that almost halves XPath complexity.

- onItemChange Path should go all the way down to the Data Item below replicant level.
Ignore indexes! Eg, if you have structure a/b/c/d/myText where a,b, whatever are all
replicant containers, you just register one handler with the 'a/b/c/d/myText' Path.
It'll fire when myText changes in any of the resulting tree 'myText' elements.

- You obviously know about "getChildren". Why don't you really use Children Arrays?
Something like this ".../getaways_group/getaways[" + index + "]/w_rate1" notation is next to
impossible to properly code, maintain or debug. It is bad with the single replicant level,
just imagine it with the replication nested three deep.

Take a look at [post=110382]this[/post] sample, perhaps it may help a little. Good luck.

Data Objects.zip