nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Overriding transition comment for DeployTask?

Adam Stoller

Environment[indent]TeamSite 6.7.2 SP2 + P1
W2K3
WFM[/indent]Issue[indent]I've created my own Deploy.java class that extends the DeployURLExternalTask class. This works just fine from a functional perspective.
The problem we have is that the transition is handled via the super-class and the transition comment that gets placed in there is the output of the deployment process - e.g.:

 Locating OpenDeploy service.
 Got OpenDeploy service
 >>>>>-- Start deployment ****/od_wf_flist38715.
          iwodstart running in default synchronous mode.
          Need to wait for deployment to complete.
 >>>>>-- Deployment ****/od_wf_flist38715 finished:
          ID: m171     Start time: Mon Apr 26 16:52:09 EDT 2010
          UUID: 94d3b490-5175-11df-9ec3-9702ccafdcaa
          Status: Completed
          Status details: 
          ...

While this information is great to have on failure of a deployment, on success - the users of the system would prefer something simple like:

Deployment to **** Succeeded

[/indent]Does anyone know if there's a way to override the default transition comment for a successful deployment (and if so - how)?

Find more posts tagged with

Comments

Crsb

do you execute the transition yourself? meaning do you check the results and choose the transition? in this case you should be able to add your comment, something like this:


task.chooseTransition(failureTransition, "Custom comment");

the default in iwov code is similar to this:


task.chooseTransition(failureTransition, resultBuffer.toString());

Adam Stoller

do you execute the transition yourself? meaning do you check the results and choose the transition? in this case you should be able to add your comment, something like this:
task.chooseTransition(failureTransition, "Custom comment");
the default in iwov code is similar to this:
task.chooseTransition(failureTransition, resultBuffer.toString());

What part of the following wasn't clear?

The problem we have is that the transition is handled via the super-class

If I was performing the transition in my class this all becomes a non-issue and I never would have posted it.
My class takes care of programmatically setting some variables and then calling the super-class to perform the actual deployment. Once I hand off to the super-class, it takes care of performing the deployment and performing the transition.
My question is for anyone who may have access to / or tinkered with the super-class code and who may know if there's a variable or method I can use to manipulate the comment that is used for a successful deployment transition.
I'm trying to avoid an overly hackish solution.

Migrateduser

He's trying to help you out. Be a little nicer.

Adam Stoller

He's trying to help you out. Be a little nicer.

I was being nice - if I wasn't being nice I would have stopped right after quoting myself.

nipper

I was being nice - if I wasn't being nice I would have stopped right after quoting myself.

I think you need to break out the iPad again.

Crsb

What part of the following wasn't clear? If I was performing the transition in my class this all becomes a non-issue and I never would have posted it.
My class takes care of programmatically setting some variables and then calling the super-class to perform the actual deployment. Once I hand off to the super-class, it takes care of performing the deployment and performing the transition.
My question is for anyone who may have access to / or tinkered with the super-class code and who may know if there's a variable or method I can use to manipulate the comment that is used for a successful deployment transition.
I'm trying to avoid an overly hackish solution.

Sorry I overlooked that part of your post... I had similar issue last year where i had to modify the way the deploy task transitions. my issue was that the deploy task in 6.7.1SP1 always transitioned to failure every time the deployment was not complete, this included when the deployment was queued. so i had to copy and modify DeployURLExternalTask code to analyze the deployment results and transition thru queued transition if the deployment was queued. this was much easier than rewriting the whole deploy task.

As you see in the code snapshot, resultbuffer, that is used for transition comment, is created locally and is set by start.runIt(resultBuffer) and I don't see a way you could manipulate it externally.

this is snapshot of the code running the deployment:


...
 StartDeploy start = getStartDeployHelper();
...
        String taskOwner = task.getOwner().getName();
        start.setUserName(taskOwner);
        start.setDeploymentName(task.getVariable("odDeploymentName"));
        start.setExtTaskID(task.getId());
        start.setOdHost(task.getVariable("odHost"));
        String portVar = task.getVariable("odPort");
        if(portVar != null && portVar.length() > 0)
            start.setOdPort(Integer.parseInt(portVar));
        String instName = task.getVariable("odDeploymentInst");
        if(instName != null && instName.length() > 0)
            start.setInst(instName);
        File tempFile = createTempFilelistFile(task);
        Vector keyValuePairs = getSubstKeyValuePairs(task, tempFile);
        start.setSubsKeyValue(keyValuePairs);
        String status = task.getVariable("odDeploymentStatus");
        String mt = "";
        if(status == null || mt.equals(status))
            status = "Started";
        else
            status = "Restarted";
        if(LOGGER.isDebugEnabled())
            LOGGER.debug((new StringBuilder()).append("about to call task.setVariable(odDeploymentStatus, ").append(status).append(")").toString());
        task.setVariable("odDeploymentStatus", status);
        LOGGER.debug("returned from task.setVariable()");
        StringBuffer resultBuffer = new StringBuffer();
        try
        {
            start.runIt(resultBuffer);
        }
        catch(Exception e)
        {
            StringWriter writer = new StringWriter();
            PrintWriter printer = new PrintWriter(writer);
            e.printStackTrace(printer);
            printer.close();
            LOGGER.warn((new StringBuilder()).append("caught this from start.runIt(): ").append(e.getMessage()).append("\n").append(writer.toString()).toString());
            if(getCaught() == null)
                setCaught(e);
        }
....
        if(getCaught() != null)
            task.chooseTransition(failureTransition, getCaught().getLocalizedMessage());
        else
        if(StartDeploy.deploymentCompletedWithError(code))
            task.chooseTransition(failureTransition, resultBuffer.toString());
        else
        if(StartDeploy.deploymentFailed(code))
            task.chooseTransition(failureTransition, resultBuffer.toString());

Adam Stoller

... I had similar issue last year where i had to modify the way the deploy task transitions. my issue was that the deploy task in 6.7.1SP1 always transitioned to failure every time the deployment was not complete, this included when the deployment was queued. so i had to copy and modify DeployURLExternalTask code to analyze the deployment results and transition thru queued transition if the deployment was queued. this was much easier than rewriting the whole deploy task.

As you see in the code snapshot, resultbuffer, that is used for transition comment, is created locally and is set by start.runIt(resultBuffer) and I don't see a way you could manipulate it externally.

this is snapshot of the code running the deployment:
...

Thanks - that's what I was afraid of. I guess I'll have to handle this some other way (like pushing another transition comment onto the stack - probably with an otherwise useless externaltask following the success transition of the deployment task.