Rules Execution - Issue

Hi All, I trying to execute a rule which I have written in TS/LS7.3.2. I called OOTB External and have given a Rule Datum as a parameter to that Datum.

            <External>
              <Parameters>
                <Datum ID="D01" Type="Rule" Name="RulesToExecute" Exposed="true">
                  <Option Selected="true" Order="1">
                    <Display>Link</Display>
                    <Value>abc.rule</Value>
                  </Option>
                </Datum>
              </Parameters>
              <Object Scope="local">com.interwoven.livesite.external.runtime.RulesEngineExternals</Object>
              <Method>executeRules</Method>
            </External>

But this rule is not executing and is failing with following exception. So looks like the path formed for fetching the rule is not correct (square braces are coming in the path). But what can I do to get rid of those braces so that it works fine? I can probably modify the code and make it work. But both the options are OOTB, so shouldnwork in conjunction with each other? Am i missing something?

Thanks in advance

Caused by: java.lang.RuntimeException: Failed to get data //servername/default/main/sitename/WORKAREA/shared/iwov-resources/rules/[abc.rule]
at com.interwoven.livesite.file.impl.CsFileDal.getStream(CsFileDal.java:310)
at com.interwoven.livesite.rules.engine.RulesEnginePreviewRequestBuilder.loadRuleXml(RulesEnginePreviewRequestBuilder.java:300)
at com.interwoven.livesite.rules.engine.RulesEnginePreviewRequestBuilder.buildRuleData(RulesEnginePreviewRequestBuilder.java:136)
at com.interwoven.livesite.rules.engine.RulesEnginePreviewRequestBuilder.<init>(RulesEnginePreviewRequestBuilder.java:104)

Find more posts tagged with

Comments

interDev

Any Takers?

Rick Poulin

I'll take a stab at it, but I haven't put much effort into reproducing your issue so take this advice with a grain of salt.

Looks to me like the issue is your choice of Datum type. If you used <Datum Type="String" Name="RulesToExecute">abc.rule</Datum> as a test, it would probably work. Because you used something with multiple Options, the context.getParameterString() call returns what looks like an array -- if you had more than one option selected, it might pass something like [abc.rule,xyz.rule]. Unfortunately for you, the OOTB executeRules() call wants to split on commas, but it doesn't remove the brackets.

Assuming all of the above is true, I'd suggest writing your own external that correctly parses the data and then hands it off to context.executeRules():

public Document executeRules(RequestContext context) {
  Document doc = DocumentHelper.createDocument();
  Element result = doc.addElement("response");
  String rulenames = context.getParameterString("RulesToExecute");
  if (null == rulenames) {
    LOGGER.error("Unable to find 'RulesToExecute' parameter.");
    return null;
  }

  /** This is the missing part **/
  if (rulenames.startsWith("[") && rulenames.endsWith("]")) {
    rulenames = rulenames.substring(1, rulenames.length() - 1);
  }
  /** End addition **/

  StringTokenizer tokens = new StringTokenizer(rulenames, ",");
  List rulesToExecute = new LinkedList();
  while (tokens.hasMoreTokens()) {
    rulesToExecute.add(new RuleExecDef(tokens.nextToken()));
  }
  context.executeRules(result, rulesToExecute);
  return doc;
}

interDev

Yes you are right and I agree that your solution will work but my core problem is I am using OOTB rules Datum which returns this array and i asume it should work by default with OOTB rules execution method?

or how to execute the rules which we select through Rules Datum? Is there another way to execute rules selected using Rules Datum?

Thanks Rick for your help !

Kalam

HI,

From the log it seems you are trying to execute the rule in the Teamsite and not in the runtime.

The error shows that the rules engine is not able to load the Rule you have created. Can you please create e very simple rule and try to execute.

I used this to test it out. In the datum i used the below

Attaching the simple rule in which the condition is always true and the action is setting a cookie value.

Please try this simple thing and let us know.

Thanks

Kalam

Rick Poulin

interDev wrote:

or how to execute the rules which we select through Rules Datum? Is there another way to execute rules selected using Rules Datum?

There's also a RulesEngineController#executeRules() that you can use, but the code for that looks like it would have the same issue.

I think it's possible you may have simply run into a bug in your particular version of the product, caused by a mismatch between executeRules() and getParameterString().

Kalam

Hi Rick,

I can see this issue in TS 732 and TS 741 also.May be bug in both versions

Thanks

Kalam

You can try something like this.

     public Document executeRules(RequestContext context) {
               Document doc = DocumentHelper.createDocument();
               Element result = doc.addElement("response");
               ParameterHash parameters = context.getParameters();
                Object Rule = parameters.get("rule");

           if (Rule != null){
               List<RuleExecDef> rList = new LinkedList<RuleExecDef>();
               if (Rule instanceof ArrayList){
                   List<String> Rules = (ArrayList<String>) Rule;
                   for (String rt : Rules) {
                       rList.add(new RuleExecDef(rt));
                   }
               } else {
                   String rt = (String) Rule;
                   if (StringUtils.isNotBlank(rt)){
                       rList.add(new RuleExecDef(rt));
                   }
               }
               if (rList.size() > 0) {
                   context.executeRules(result, rList);
               }
                return doc;
           }

           }

interDev

Thanks Rick and Kalam. I was out for few days.. You guys confirmed what I have experienced so far. I will write the custom rule executor to overcome the problem but I was more concered if I was executing the OOTB rules in right way and in this case I was.

Thanks for your help !

SAK25

Hi,
I am.running into the same issue as you have mentioned. Default rule darum.is attaching [] to the rule. It is showing the same error. Could you please update on how did you resolve the issue? Did you write a custom external code or used some other way to execute the rule?

Ashish_Sangal

Hi,

I suppose there is some issue when you pass "Rule" datum to external. Try using simple datum as mentioned below and see if it works for you.

<Data>
  <Datum ID="D01" Type="Rule" Name="RulesToExecute" Exposed="true" StopOnFirstTrue="true">
    <ContentTypes>
      <ContentType>$ALL</ContentType>
    </ContentTypes>
    <ActionParameters/>
    <Option Selected="true" Order="1">
      <Display>Type1</Display>
      <Value>type1.rule</Value>
    </Option>
  </Datum>
</Data>

Notes: Name of the datum must be "RulesToExecute".

I tried this on 7.2.1, 7.3.0 and 7.4.0 and its working fine.

Mark this as a solution, if it resolves the issue.

Thanks,

Ashish Sangal