iw_if with greater and less than condition in an Optimized Way

Hi,

I am using <iw_perl> in my TPL and at the same time doing Code Optimization for the same.

I have an <iw_if> condition to be optimized which contains (less than, greater than, && ).

Help Needed.

This is the <iw_if> condition in my TPL :

<iw_if expr=' {iw_value name="$n"/} > 99 && {iw_value name="$n"/} < 300 && {iw_value name="$n"/} eq {iw_value name="$SomeValueFromDCR"/}'>

<iw_then>

</iw_then>

<iw_else>

</iw_else>

</iw_if>

Perl Version : 5.8.2

TeamSite : 7.4.1

Thanks in Advance.

Find more posts tagged with

Comments

Adam Stoller

I'm not sure I understand the question you are asking?

Will $n ever be equal to $SomeValueFromDCR if $n is outside the bounds of 99-300?

If not - then you can get rid of the range test and just leave the equality test, thus making the test more optimal and getting rid of the need for the greater-than/less-than conditions.

Even if it is possible for $n to equal $SomeValueFromDCR with $n outside the bounds of 99-300, which is the more restrictive test in practice? The range or the equality? If the equality is more restrictive, you should put that test before the range tests, thus making the overall conditional more optimized.

test2.rptdesign

test2 export fit to auto.pdf

test2 export fit to actual size.pdf

Ashraf_shk786

$n will be equal to $SomeValueFromDCR, as I am iterating it under a for loop.

I am trying to figure out, how can I make the <iw_if> condition more optimal ?

Probably, as you can see in my code use of greater and less than symbols AND OR conditions are verifying condition under each expression. I would want to find any condition that can reduct number of expression here and improve the quality of code as well.

Can you lead me to reduce it in terms of lines, space And optimed syntax.

Or any other suggestion to do it?

Thanks in Advance.

HTML5 Charts -- Area Chart with Threshold zone like.rptdesign

HTML5 Area Chart with different zones.png

nipper

You can convert this to a Perl template. Then you would be able to write the logic in Perl and output the correct data.

Adam Stoller

As I said, you are not providing sufficient information about the value of $n.

Right now you have, essentially:

if ($n > 90 && $n < 300 && $n eq $SomeValueFromDCR) {
  ...
}
else {
  ...
}

Note that the operator you used to compare the value to $SomeValueFromDCR is basically wrong since $n clearly needs to be an integer value and not a string value.

My question was - will $n ever be equal to $SomeValueFromDCR when it is outside the bounds of 91-299?

If not - then you can simplify the test to be just:

if ($n == $SomeValueFromDCR) {
 ...
}
else {
 ...
}

Not only does the above simplify the test, but it also simplfies the writing of the test if you want to use the XML-tag syntax, i.e.:

<iw_if expr="$n == $SomeValueFromDCR">
 <iw_then>
  ...
 </iw_then>
 <iw_else>
  ...
 </iw_else>
</iw_if>

Then there's the question of whether you need the else-clause or just the if-clause, since you've never provided the complete requirements of the code you're trying to write we're all just guessing based on what you have provided.

As for "optimization" - well, again, not knowing all the parameters in play makes it difficult to provide suggestions beyond what I have provided above and what @nipper indicated - which is that since you are already using <iw_perl>...</iw_perl> blocks, you could just write the whole thing in Perl and avoid the XML layer of <iw_if>...</iw_if> since that has to get converted into Perl first before it actually gets evaluated.

Ashraf_shk786

Thanks for your suggestions : @ghoti and @nipper

I will try to write the whole thing in <iw_perl> ... </iw_perl> avoiding the xml layer.

May be this can help to achieve what I am trying to achieve.

Thanks for your valuable time and contribution.