nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Workflow not deleting all the files.

Methy

Hi,
I have an external task in the workflow to delete the files attached to the task. Below is the java file that is called to do this functionality. But the problem is, it only deletes n-1 files. That is, if I have 5 files attached to the task, it deletes only 4 files and last file is not getting deleted. But it fetches all 5 files and displays the delete command for all 5 files. Any thoughts on why this is happening?

private void deleteFiles(CSExternalTask task, Runtime rt)
throws CSAuthorizationException, CSRemoteException, CSObjectNotFoundException, CSExpiredSessionException, CSException, IOException {
CSAreaRelativePath[] areaRelativePaths = task.getFiles();
String file;
createlogfolder.info("File Count:"+areaRelativePaths.length);
for (CSAreaRelativePath areaRelativePath : areaRelativePaths) {
file=areaRelativePath.toString();
createlogfolder.info("file List:"+file);
String Deletecmd= "/opt/iw/iw-home/TeamSite/bin/iwdeltaskfile"+" "+task.getId()+" "+file;
Process pr= rt.exec(Deletecmd);
BufferedReader errorReader = new BufferedReader(new InputStreamReader(pr.getErrorStream()));
LOGGER.error("DeleteFileList cmd:"+Deletecmd);
}
}

Thanks.

Find more posts tagged with

Comments

Rick Poulin

Dear **** man! Whoever wrote this code needs to go back to Java school.

The likely problem is that you don't appear to be logging the STDERR, and you're not reading the STDOUT at all. So the command could be failing with a very obvious message and you'd never know. Or maybe you've got a funny character in that 5th file and it's not interpreted as a valid cmd line parameter, because you're not passing params to the Runtime object properly. This would have been better: rt.exec(new String[] { "path/to/iwdeltaskfile", String.valueOf(task.getId()), file});

Now that aside, this code is super flawed. The whole point of the Java API was to get away from forking a new thread for each interaction with the iwserver, and here you are actually breaking that model and introducing a boatload of overhead that you don't need, and can't effectively handle exceptions. So, remove all that **** about forking a process and use something like this instead:

[PHP]
// TODO: add proper exception handling
CSAreaRelativePath[] files = task.getFiles();
task.detachFiles(files);
CSArea workarea = task.getArea();
for (CSAreaRelativePath path : files) {
workarea.getFile(path).delete();
}
[/PHP]

Migrateduser

Dear **** man! Whoever wrote this code needs to go back to Java school.

Like.

MrShake

Not to step off topic... however. There is no need for insult here.....

Some of us are asked to do things we have little or no training in. Bad coding, rookie mistakes, etc, are to be expected. Bashing the writer of the code serves no purpose. Neither does acknowledging that negativity.

Migrateduser

Not to step off topic... however. There is no need for insult here.....

Some of us are asked to do things we have little or no training in. Bad coding, rookie mistakes, etc, are to be expected. Bashing the writer of the code serves no purpose. Neither does acknowledging that negativity.

Then one could argue that those types of people should take some training before accepting a job they are not qualified to do. A certain level of understanding is required before seeking help in a place like this. This is a public forum, and if you post crappy code, someone is likely going to tell you it's crappy code. If you can't handle that, don't post your crappy code in a public forum. Here endeth the lesson.

ISCBorisB

Not to step off topic... however. There is no need for insult here.....

Some of us are asked to do things we have little or no training in. Bad coding, rookie mistakes, etc, are to be expected. Bashing the writer of the code serves no purpose. Neither does acknowledging that negativity.

Methy got expert advice (with code) for free, in couple hours after asking a question. Where exactly did you find an "insult" in that?

Rick might have just ignored the thread (personally, I often do if I do not like what I see). After all, he's busy and his time is expensive.
Ask Methy if he would consider that a better (more respectful?) outcome.

Citing Eric Raymond: "Don't expect to be treated like a fragile doll just because [...] of theatrically hypersensitive soul and delusions of entitlement".

CrosstabFilter.PNG

CustomCrosstabCategory_plusFilter.rptdesign

Rick Poulin

Not to step off topic... however. There is no need for insult here.....

Some of us are asked to do things we have little or no training in. Bad coding, rookie mistakes, etc, are to be expected. Bashing the writer of the code serves no purpose. Neither does acknowledging that negativity.

At what point was I insulting or bashing the OP? By your own conclusion, I'm pointing out a lack of training, nothing else. My goal by being more expressive is to point out just how far the posted code was from an "ideal" solution, not in character count but in design approach. The OP might've fixed the immediate problem, but encountered much worse down the road.

As a consultant, I work with lots of people that are lacking the proper training to support this solution, for reasons often out of their control. If nothing else, a code review by external consultants can often help build the business case for getting said folks sent on training. In this case, I just wanted to make sure that the OP wasn't under the illusion that this was bulletproof code, or even the best approach to implementing the requirement.

ISCBorisB

It's remarkable how there are always people who never have time to help others
but find plenty of it to teach us what we should and should not be doing.

Bhargav Coca

It's remarkable how there are always people who never have time to help others
but find plenty of it to teach us what we should and should not be doing.

Well said, its true about so many people in this Form

mart2001

You should have typed Forum instead of Form. :-)

j/k!!

Like

Well said, its true about so many people in this Form