FileDal isFile not working as expected

I've been using FileDal() to check if a file exists in the file system but when I use the function isFile to test if the path is actually a file it is returning false.

If I use the exists() function then it returns true. So I know the file is there.

Are there any known issues with this class?

Find more posts tagged with

Comments

Rick Poulin

There's different implementations of this interface depending on which side we're talking about.

On Livesite, the underlying implementation uses java.io.File's exists() and isFile() methods, so it should return exactly what you'd expect.

On Teamsite, it uses the CSSDK. exists() means the vpath exists and doesn't point to a CSHole. isFile() means the vpath exists and points to a CSSimpleFile -- symlinks, holes and other things will return false.

tbkeith

Yes I meant to specifiy this is on TeamSite and I am trying to check if a DCR file exists.

Example code:

String dcr = context.getFileDal().getRoot() + "/" + pathToDCR

if (context.getFileDal().isFile(dcr)) {

// file exists

}

Rick Poulin

You're right. I looked at it again and there is a bug indeed (in 7.3.2 anyway; you didn't state your version).

CsFileDal#isFile() checks whether f.getKind() == CSFile.KIND instead of f.getKind() == CSSimpleFile.KIND.

tbkeith

I'm on TS7.1

Are those CS classes not for LS?

Ive decompiled the code and it looks like under the hood it just uses Java's File class for isFile

// extract from com.interwoven.livesite.file.impl.FileSystemDal

public boolean isFile(String path)
{
File f = new File(path);
return (f.exists()) && (f.isFile());
}

Unsure if that's the right place though.

Rick Poulin

You're looking at the runtime-side implementation. The one in TS uses a different class (Spring does the wiring at runtime for either one). There's definitely a bug here, and given your version number, they'll tell you to upgrade (not that it'll help unless they fixed this in 7.4). Your best bet is to not use that API and find a workaround, such as calling FileDal#getSteam() and catching the ClassCastException.

tbkeith

Thanks for your help I will write a workaround.