perl - issue reading deployment file list line by line

Hi, I have a formatting issue while reading a deployment list file in perl and hoping someone would help me out here. Thanks in advance

Details:

we are using Teamsite 6.7.1 and have workflows created out of .wft files. And the deployment task calls a perl file for deploying files.

Before deployment, perl script creates a list of the files to be deployed and each entry is appended by \n. Code looks like this:

$filelist = "D:\\Nagesh\\filelist.$$";
open (LIST, ">$filelist");

foreach $file_to_be_deployed (@iw_files)
{

  # REMOVE all from the path but the actual file name
  local @brokenpath = ();
  @brokenpath = split (/\//, $file_to_be_deployed);

  # PRINT the FILENAME to the list and close it
  print LIST "$brokenpath[$#brokenpath]\n";

}
close (LIST);

I'm attaching one sample filelist that got created in this fashion (please remove .txt for testing/analyzing)

Issue: immediately after deployment, the perl script reads the same file list and sends an email with the list of the files that got deployed. During this process, while reading the file it is ignoring \n between the files and printing the list as

file 1 file 2 file 3....

Expected outcome is

file 1

file 2

file 3

Another interesting observation is: if I take out the code for reading the file and sending the email to another sample perl file and execute it in the command prompt, the format is coming fine. The read operation is able to consider each file as one line. The issue occurs only when the code gets executed as part of the workflow

Please help me on how I can make the perl script reach each file as one line instead of all files being read as one single line

here is the code to read the file

$filelist = 'd:\Nagesh\filelist.1852';
open(T,$filelist) || die "Can't open file: $!";
my $filesDeployed = "files deployed are ";

while (<T>) {

my $pos = index($_,$substrng);

  #to remove templatedata\data entry
  if ($pos != -1){
   $_ = substr($_,0,$pos);
  }

$filesDeployed .= " $_";
}
close T;

Considering the attached file, I'm getting the filelist as below in my email
bank\nageshtest\test_revert_process.html templatedata\generic_pages\standard_evergreen_no_rtnav_page\data\testing_revert_process

And the expected outcome in my email is:

bank\nageshtest\test_revert_process.html

templatedata\generic_pages\standard_evergreen_no_rtnav_page\data\testing_revert_process

I dont understand while the file reading operation is behaving different when triggered on command prompt and when triggered through workflow task. Please help!!!

Find more posts tagged with

Comments

nipper

You are probably sending an HTML email and htenew line is ignored. Put a tag in between.

Quick_Learner

Hi Andy, are you suggesting that I put while creating the file list itself? I did that too. The problem is that if I use while creating file list, the files are not being recognized for deployment.

Thanks,

Nagesh K

DisplayField.jpg

nipper

Do a view source of your email and see if there is any HMTL.

Sometimes tags do not show up correctly, often I use <div> </div> in between.

This should be in the email script and not the script that generates the filelist.

You can also set the script to output text email instead of html and see if it helps.

Quick_Learner

Hi Andy,

the problem here is that when I read the file, the entire file content is being read into a single line. So, even if I place a after the first line read, it is not helping. And does work in the email. so this is not the issue

I also tried to split the line using space as follows, but it did not work:

split /s/, $_

I also tried split / /, $_

I'm also attaching the source of the email. As you can see both the files are being read as single line and so I'm not able to place a in between them. And split did not work. I guess I even tried splitting them with \n as delimiter, but it did not work.

nipper

ok so read one line at a time instead of slurping it in.

while(<IN>){
$txt .= $_." ";
}

Quick_Learner

That is what I'm exactly doing. And the problem is that

when the first read happens: while (<IN>) {

the value now contains both files instead of one. So when this line executes for the first time $txt .= $_." ";

the value of $txt is file1 file2 . (the space between file1 and file2 is actually \n which is being ignored by the email)

where in the expected value is file1

Thanks,

Nagesh K

nipper

Makes zero sense.

I would try a quick lab setup and see if it works because your code is correct

Are you certain you are invoking the same code in the WFT email?

Maybe some logging will help

select all parameter.rptdesign

BIRT Example to include ALL in parameter - beforeOpen and fitler example__cwong.rptdesign

Quick_Learner

Yes Andy, I'm sure I using the same code. I also added a log statement to see what is coming in the first read. And I was shocked to see that both lines are showing up. I will test again to be doubley sure. And I will also print them in the email.

In the meanwhile, can you please let me know how do I split the line using new line as delimiter. Somehow the examples in find in internet does not work Smiley Sad

Thanks,

Nagesh K

nipper

Maybe on DOS, perl wants "\r\n"

CR/LF

Try changing your end of line to "\n\r"

Quick_Learner

Hi Andy, I tried the \r\n, but the issue persists. And I was so involved into this formatting issue that I forgot about the other option of using $task->GetFiles (I did think about this at the start). So, I went ahead and changed my logic to retrieve the files and listing them in the email. Now, the email looks fine Smiley Happy .

Thanks for all your support on this. And just out of curiosity, did you get a chance to replicate the issue at your side?

Thanks,

Nagesh K

Adam Stoller

The code posted is, based on the comments and naming of variables and such - horribly written - and it is difficult to know what you are and are not attempting to do with this list of files and thus what is or is not properly happening.

Based on what was posted - I'd suggest something like the following:

my $filelist = "D:/Nagesh/filelist.$$"; #=# I prefer using jobid or taskid value
open LIST, '>', $filelist || die "[w] '$filelist' ($!)"; #=# ALWAYS CHECK FOR ERROR
foreach my $file_to_be_deployed (@iw_files) {
# REMOVE all from the path but the actual file name
    #=# Questionable for workflow-driven deployments, but ...    $file_to_be_deployed =~ tr|\\|/|;
    $file_to_be_deployed =~ s|^.*/||;
# PRINT the FILENAME to the list and close it
    #=# You are only closing the file after ALL the entries have been processed    print LIST "$file_to_be_deployed\n";
}  
close LIST;
#--------------------------------------------------------------------
my $filelist = "D:/Nagesh/filelist.1852"; #=# I prefer using jobid or taskid value
my $filesDeployed = "files deployed are:<br/>";
open T, '<', $filelist || die "[r] '$filelist' ($!)";
foreach my $entry (<T>) {
    chomp $entry;
    $filesDeployed .= "$entry<br/>\n";
}
close T;
$filesDeployed .= "<p></p>\n";
#....
print $filesDeployed;

Quick_Learner

Hi Adam,

Thanks for the suggestion. I will try it out and see if that solves the issue. And yes, I agree that code is horrible. Unfortunately, I'm not allowed to change much.

Thanks,

Nagesh K