TypeError: Cannot convert null to an object.

HI, All,
Birt 3.7, the report needs two two parameters, let's say parA and parB, both are not required and but can with multiple values. And here is the way I set for both parameters:
var parAArray=new Array(); 
parAArray=params["parA"].toString().split(","); 
var myparA="("; 
for(var parACount = 0; parACount < parAArray.length; parACount++){ 
 myparA = myparA + "'" + BirtStr.trim(parAArray[parACount].replace("=","")) + "'"; 
 if(parACount+1 < parAArray.length){ 
 myparA = myparA + ", "; 
 } 
} 
myparA = myparA + ")";
 
the query is just select some data from tables.
 
After the query, I added this:
if(params["parA"].value != "" && params["parA"].value != null){ 
 sqlText = sqlText + " and tableA.columnA in " + myparA ; 
}
 
if the parameter has value, the report runs ok, but if null, the below error shows up.
 
Here is the error info:
maximoDataSet.setQuery(sqlText); + "

A BIRT exception occurred. See next exception for more information. 
Error evaluating Javascript expression. Script engine error: TypeError: Cannot convert null to an object. (/report/data-sets/script-data-set[@id="5"]/method[@name="open"]#7) 
Script source: /report/data-sets/script-data-set[@id="5"]/method[@name="open"], line: 0, text: 
__bm_OPEN(). (Element ID:1)
 
Thanks very much for your help!

Find more posts tagged with

Comments

micajblock

you need to wrap your code in an if statement like this for when user does not select anything
<pre class="_prettyXprint">
if (params["parA"].value != null) {
your code here
}</pre>

oraBirt

Thanks very much for your time!
Tested your code, and got same error. actually, there was a similar code above like yours( please see below). not sure what is wrong here? From the logic, if no value for parA, the query should run without adding the code inside if statement.
 
if(params["parA"].value != "" && params["parA"].value != null){ 
sqlText = sqlText + " and tableA.columnA in " + myparA ; 
}
 
 <div>
 
</div>

micajblock

Your code is wrong. A multi value parameter is an array it will never equal "". It should be:
<pre class="_prettyXprint">
if(params["parA"].value != null){
sqlText = sqlText + " and tableA.columnA in " + myparA ;
}</pre>

oraBirt

Your quick help is really appreciated!
I did follow your instruction and used the code as below, somehow got same error(TypeError: Cannot convert null to an object) when I select "Null value" during previewing the report.
 
if(params["parA"].value != null){ 
sqlText = sqlText + " and tableA.columnA in " + myparA ; 
}
<div>
 
and the debug file error:
error Dataset[dataset] fetch failed.
java.sql.SQLException: SQL statement to execute cannot be empty or null
 
Hope the attached file can help! Thanks!
 
 
</div>

shamo

Why is your ; before the } ?

oraBirt

Thanks, do you mean the red semi colon marked below? tested without it, got same error.
 
if(params["parA"].value != null){ 
sqlText = sqlText + " and tableA.columnA in " + myparA ; 
}

micajblock

You need the same if around this part of you code.
<pre class="_prettyXprint">
glaccountArray=params["Glaccount"].toString().split(",");</pre>

oraBirt

Yes, it worked!! Thanks so much for your great help!!
but not sure why the if statement should be there for null values? from the logic, if the parameter is null, it will not execute the next statement, that is : sqlText = sqlText + " and tableA.columnA in " + myparA;
 
Another question is there is an invalid binding error inside maximo after the report is imported into maximo, while the parameter is configured as valuelist and bind to the corresponding field ? missied something from designer side or something was wrong ?
 
Thanks a lot!

micajblock

It fails because you cannot do a toString().split() on a null object. In any case a better what if doing this is instead of this:
 
<div>
<pre class="_prettyXprint">
// for glaccount
var glaccountArray=new Array();
glaccountArray=params["Glaccount"].toString().split(",");
var account="(";

for(var glaccountCount = 0; glaccountCount < glaccountArray.length; glaccountCount++){
account = account + "'" + BirtStr.trim(glaccountArray[glaccountCount].replace("=","")) + "'";
if(glaccountCount+1 < glaccountArray.length){
account = account + ", ";
}
}
account = account + ")";</pre>
</div>
This (one line of code):
<div>
<pre class="_prettyXprint">
// for glaccount because a multi-select parameter is already an array
if(params["Glaccount"].value != null){
account = "(" + params["Glaccount"].value.join(",") + ")";
} </pre>
</div>

micajblock

In regards to your binding question. In the table you have a binding for a column psu_classification that does not exist in the query. Deleting a data item from the table does not remove the binding. Just because it is removed from the table does not mean it is not uses elsewhere in an expression or code (hence we do not remove the binding automatically). You need to remove the binding manually.

oraBirt

Thanks so much for your great help!
Not sure if I added this correctly or not , now the error is: cannot find function join in object...
 account = "(" + params["Glaccount"].value.join(",") + ")";
Also, user can pick one or multiple values for this parameter.
 
For the databinding, I added this field back, and still got invalid binding from maximo application.
Attached another copy here, any idea is appreciated!!

micajblock

My apologies. I thought Glaccount was a BIRT multi-select parameter and it is in fact a string. So all you really need (assumming Maximo passes the multiple values as a comma delimited string) is this:
<pre class="_prettyXprint">
// for glaccount as a comma delimited string
if(params["Glaccount"].value != null){
account = "(" + params["Glaccount"].value + ")";
} </pre>
 In regards to the binding, they actually are based on an internal ID so adding the column back will not fic it. Remove from both places and see if it works.

oraBirt

Thanks very much for your help!
Actually, you were correct. Glaccount is a BIRT multi-select parameter, but user is allowed to select only one value from parameter list. ( is this possible?)
About data binding, we need the field to be there now. not sure what was wrong here to get invalid binding.
Is there a way to step by step debug the code inside birt designer like in other programming languages?
Again, really appreciate your great help!

micajblock

In the design you attached Glaccount is a string not a multi-select. 
 
In regards to the binding. Remover from both places and see if it works. The add the column to the query and then click on the refresh button in the table binding tab.

oraBirt

Thanks very much!
The attached report works fine, not sure why mine does not work.
The difference between the two reports is the parameters in atest report are not required, and there are some if statements based on the parameters. bb report has no problem after published in maximo for data binding too.

micajblock

Do you have a current version of atest.rptdesign with my suggestions? The reason the original design failed is that the line below will fail if Glaccount does not have a value.
<pre class="_prettyXprint">
glaccountArray=params["Glaccount"].toString().split(",");</pre>
Do you know what Maximo sends for multi value parameters? I would think it is a comma delimited list. So I really do not understand why you create a comma delimited list from a comma delimited list:
<div>
<pre class="_prettyXprint">
// for glaccount
var glaccountArray=new Array();
glaccountArray=params["Glaccount"].toString().split(",");
var account="(";

for(var glaccountCount = 0; glaccountCount < glaccountArray.length; glaccountCount++){
account = account + "'" + BirtStr.trim(glaccountArray[glaccountCount].replace("=","")) + "'";
if(glaccountCount+1 < glaccountArray.length){
account = account + ", ";
}
}</pre>
</div>

wwilliams

if this is Maximo and you want multiple values with your parameter use this in the where
+ MXReportSqlFormat.createParamWhereClause("workorder.glaccount", params["Glaccount"].toUpperCase())
 
Then the user can enter glaccounts separated by a comma

oraBirt

Thanks for all the help!
So far the report works fine from the designer , but does not return anyd data from maximo 75.
The problem is :
1. the following code does not work in maximo:
if( params["wo"].value == undefined){ 
sqlText = sqlText + " and labtrans.glcreditacct in " + account 
} 
else 
{ 
sqlText = sqlText + " and labtrans.refwo in " + wo ; 
}
 
2. a label showing text based on parameter value does not work, even it works from designer.
the label is to tell user if both wo and glaccount have values, it will display the lable with red color, saying not have two parameters at the same time. But maximo always displays this label whether user enter two parameters or not.
 
any help is really appreciated.

micajblock

<ol><li>Why are you using 'undefined'? My guess is that Maximo sends a value.</li>
<li>Label? Use a data item with an expression.</li>
</ol>

oraBirt

Can you please give me an example for displaying/hiding the label? Thanks very much!
The current code (shown below) works fine from birt designer, but not from maxiimo. the code is to set the label visibility to hide , and add the code to fx funciton,
if (params["wo"]value != null && params["Glaccount"]value != null)
{
false;
}
else {
true;
}

micajblock

Then Maximo is probably sending a empty string not null. Try testing for that also. If it works in the designer than the code is OK.